Differential D15012

Allow profile menu items to be disabled
ClosedPublic
Actions

Authored by epriestley on Jan 13 2016, 6:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 1:27 PM

	Unknown Object (File)
	Fri, Dec 13, 3:29 AM

	Unknown Object (File)
	Wed, Dec 11, 1:34 AM

	Unknown Object (File)
	Mon, Dec 9, 2:24 PM

	Unknown Object (File)
	Sun, Dec 8, 3:58 PM

	Unknown Object (File)
	Sun, Dec 8, 5:27 AM

	Unknown Object (File)
	Fri, Dec 6, 10:11 PM

	Unknown Object (File)
	Mon, Dec 2, 11:20 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP473693786b86: Allow profile menu items to be disabled

Summary

I made this a dropdown (currently: "Visible" or "Disabled") since I imagine we miiiight want to add a "Hidden, but click 'More' to reveal" state or do other special stuff in this vein. Not 100% sold on that but seemed within the realm of plausibility.

Test Plan

Screen Shot 2016-01-13 at 10.40.13 AM.png (1×1 px, 149 KB)

Diff Detail

Repository

Branch

ppanel5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10093
Build 12230: Run Core Tests
Build 12229: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36259.Jan 13 2016, 6:42 PM

epriestley retitled this revision from to Allow profile menu items to be disabled.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

chad accepted this revision.Jan 13 2016, 7:34 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 13 2016, 7:34 PM

Closed by commit rP473693786b86: Allow profile menu items to be disabled (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2016, 7:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

editor/

PhabricatorProfilePanelEditor.php

8 lines

engine/

PhabricatorProfilePanelEngine.php

76 lines

storage/

PhabricatorProfilePanelConfiguration.php

11 lines

PhabricatorProfilePanelConfigurationTransaction.php

1 line

Diff 36259

src/applications/search/editor/PhabricatorProfilePanelEditor.php

Loading...

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...

src/applications/search/storage/PhabricatorProfilePanelConfiguration.php

Loading...

src/applications/search/storage/PhabricatorProfilePanelConfigurationTransaction.php

Loading...