Ref T10054. This has no product impact, but prepares us for customizable side nav on "profiles" (today, projects; probably users some day; and maybe other stuff down the road).
Details
Details
- Reviewers
chad - Maniphest Tasks
- T10054: Define product direction for Project/Profile UIs
- Commits
- Restricted Diffusion Commit
rP7bde92b9c980: Begin modularizing profile panel/link construction
Clicked all links on a profile, everything was exactly the same as before.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- ppanel1
- Lint
Lint Passed Severity Location Code Message Advice src/applications/project/storage/PhabricatorProject.php:669 XHP16 TODO Comment Advice src/applications/project/storage/PhabricatorProject.php:681 XHP16 TODO Comment Advice src/applications/search/engine/PhabricatorProfilePanelEngine.php:81 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 10085 Build 12217: Run Core Tests Build 12216: arc lint + arc unit
Event Timeline
Comment Actions
I suspect we can run home off of this as well? Pretty much most of the features will duplicate (re-order, etc) and I'd still like a minimal view personally for home.
Comment Actions
Yeah, I think that should work. It's going to take a little massaging since there's no proper object to pull by PHID, but I can namespace them or something.
Comment Actions
(By "minimal", you just mean you want to be able to collapse the menu? You can already remove every application if you want, right?)