Page MenuHomePhabricator

Introduce "local names" for commits
ClosedPublic

Authored by epriestley on Jan 11 2016, 10:52 AM.
Tags
None
Referenced Files
F19098911: D14990.id36223.diff
Thu, Dec 4, 6:38 PM
F19098731: D14990.diff
Thu, Dec 4, 5:53 PM
F19030465: D14990.diff
Mon, Nov 24, 9:03 PM
F19030185: D14990.diff
Mon, Nov 24, 8:22 PM
F18832605: D14990.id.diff
Oct 25 2025, 10:16 PM
F18829139: D14990.diff
Oct 24 2025, 8:09 PM
F18768765: D14990.diff
Oct 8 2025, 5:15 AM
F18765775: D14990.diff
Oct 7 2025, 12:54 PM
Subscribers
None

Details

Summary

Ref T4245. Full commit display names (like rPaaaa) are going to be obnoxious soon in some cases (e.g., rPaaaa becomes R123:aaaa, which is much uglier) so reduce how often we show the repository in cases where it isn't really necessary to include it.

Test Plan
  • Saw no more rX on repository list view for Git/Mercurial (still present for Subversion).
  • Saw no more rX on various repository detail views, except when referencing other commits (e.g., mentions).
  • Grepped for removed getShortName().

Diff Detail

Repository
rP Phabricator
Branch
runique4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10045
Build 12154: Run Core Tests
Build 12153: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Introduce "local names" for commits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 4:57 PM
This revision was automatically updated to reflect the committed changes.