Paths

Table of Contentst

Differential D14988

Allow repository short names to be used as identifiers
ClosedPublic
Actions

Authored by epriestley on Jan 11 2016, 10:14 AM.

Details

Reviewers

chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rPa06715ccdddc: Allow repository short names to be used as identifiers

Summary

Ref T4245. This allows bin/repository update bread to work, in addition to rBREAD, R123, 123, BREAD, etc., if a repository has a short name set.

This primarily affects CLI commands (like bin/repository) and Conduit API calls. It has no normal user-facing impact.

Test Plan

Ran bin/repository update bread and such.

Diff Detail

Repository

rP Phabricator

Branch

runique2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10043
Build 12150: Run Core Tests
Build 12149: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36209.Jan 11 2016, 10:14 AM

epriestley retitled this revision from to Allow repository short names to be used as identifiers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4245: Make repository URIs slightly prettier.

chad accepted this revision.Jan 11 2016, 4:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2016, 4:38 PM

Closed by commit rPa06715ccdddc: Allow repository short names to be used as identifiers (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2016, 5:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

query/

PhabricatorRepositoryQuery.php

59 lines

Diff 36209

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Allow repository short names to be used as identifiersClosedPublicActions