Page MenuHomePhabricator

Fix a bad lookup in hovercards
ClosedPublic

Authored by epriestley on Jan 10 2016, 7:52 PM.
Tags
None
Referenced Files
F14037086: D14987.id36207.diff
Sun, Nov 10, 1:45 PM
F14036986: D14987.id36206.diff
Sun, Nov 10, 1:17 PM
F13977692: D14987.diff
Fri, Oct 18, 7:37 PM
F13972198: D14987.id36207.diff
Thu, Oct 17, 5:39 PM
F13968151: D14987.id.diff
Wed, Oct 16, 6:56 PM
Unknown Object (File)
Sep 20 2024, 12:40 PM
Unknown Object (File)
Sep 10 2024, 4:17 AM
Unknown Object (File)
Sep 2 2024, 1:55 PM
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPe84693f589d3: Fix a bad lookup in hovercards
Summary

If you try to pull the hovercard of something you can no longer see (maybe you loaded the page, then the policy changed) there won't be a value in the array here.

(The rest of the code anticipates this possibility.)

Test Plan

Hovered some stuff.

Diff Detail

Repository
rP Phabricator
Branch
hover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10040
Build 12146: Run Core Tests
Build 12145: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a bad lookup in hovercards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2016, 7:59 PM
This revision was automatically updated to reflect the committed changes.