Page MenuHomePhabricator

Fix a bad lookup in hovercards
ClosedPublic

Authored by epriestley on Jan 10 2016, 7:52 PM.
Tags
None
Referenced Files
F19800602: D14987.diff
Feb 28 2026, 4:35 PM
F19800601: D14987.diff
Feb 28 2026, 4:34 PM
F19693172: D14987.diff
Feb 10 2026, 8:13 AM
F19591927: D14987.diff
Feb 2 2026, 2:28 PM
F19542925: D14987.diff
Jan 22 2026, 1:39 PM
F19529720: D14987.id36207.diff
Jan 19 2026, 6:09 PM
F19523744: D14987.id36207.diff
Jan 17 2026, 7:06 PM
F19454510: D14987.id.diff
Dec 31 2025, 12:20 AM
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPe84693f589d3: Fix a bad lookup in hovercards
Summary

If you try to pull the hovercard of something you can no longer see (maybe you loaded the page, then the policy changed) there won't be a value in the array here.

(The rest of the code anticipates this possibility.)

Test Plan

Hovered some stuff.

Diff Detail

Repository
rP Phabricator
Branch
hover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10040
Build 12146: Run Core Tests
Build 12145: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a bad lookup in hovercards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2016, 7:59 PM
This revision was automatically updated to reflect the committed changes.