Page MenuHomePhabricator
Differential D14987

Fix a bad lookup in hovercards
ClosedPublic
Actions

Authored by epriestley on Jan 10 2016, 7:52 PM.
Tags
None
Referenced Files
F13819203: D14987.diff
Fri, Sep 20, 12:40 PM
Unknown Object (File)
Tue, Sep 10, 4:17 AM
Unknown Object (File)
Mon, Sep 2, 1:55 PM
Unknown Object (File)
Sun, Aug 25, 5:05 PM
Unknown Object (File)
Thu, Aug 22, 5:14 PM
Unknown Object (File)
Thu, Aug 22, 9:58 AM
Unknown Object (File)
Thu, Aug 22, 8:03 AM
Unknown Object (File)
Aug 21 2024, 6:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPe84693f589d3: Fix a bad lookup in hovercards
Summary

If you try to pull the hovercard of something you can no longer see (maybe you loaded the page, then the policy changed) there won't be a value in the array here.

(The rest of the code anticipates this possibility.)

Test Plan

Hovered some stuff.

Diff Detail

Repository
rP Phabricator
Branch
hover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10040
Build 12146: Run Core Tests
Build 12145: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36206.Jan 10 2016, 7:52 PM
epriestley retitled this revision from to Fix a bad lookup in hovercards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jan 10 2016, 7:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2016, 7:59 PM
Closed by commit rPe84693f589d3: Fix a bad lookup in hovercards (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2016, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
2 lines

Diff 36206

View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...
Phabricator · Built by Phacility