Improve error message if local Git working copy directory exists but isn't a working copy
ClosedPublic
Actions

Authored by epriestley on Jan 8 2016, 3:25 PM.

Details

Reviewers

chad

Maniphest Tasks

T9701: repo create recovery fails if empty workspace exists

Commits

Restricted Diffusion Commit
rP5592e59f9280: Improve error message if local Git working copy directory exists but isn't a…

Summary

Fixes T9701. I don't want to try to autofix this because destroying the directory could destroy important files, but we can improve the error message.

Test Plan

Faked a failure, ran repository update X, got a more tailored error message.

Diff Detail

Repository

rP Phabricator

Branch

clonerr

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9993
Build 12079: Run Core Tests
Build 12078: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36165.Jan 8 2016, 3:25 PM

epriestley retitled this revision from to Improve error message if local Git working copy directory exists but isn't a working copy.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9701: repo create recovery fails if empty workspace exists.

chad accepted this revision.Jan 8 2016, 4:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 8 2016, 4:41 PM

Closed by commit rP5592e59f9280: Improve error message if local Git working copy directory exists but isn't a… (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2016, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryEngine.php

17 lines

Diff 36165

View Options

src/applications/repository/engine/PhabricatorRepositoryEngine.php

Improve error message if local Git working copy directory exists but isn't a working copyClosedPublicActions