Convert a low-level VCS query in Diff extraction to a Conduit call
ClosedPublic
Actions

Authored by epriestley on Jan 8 2016, 1:53 PM.

Details

Reviewers

Maniphest Tasks

T2783: Make working-copy operations service-oriented
T9319: Accessing image file in Diffusion must not generate error (unhandled exception)

Commits

Restricted Diffusion Commit
rPda3963b009ce: Convert a low-level VCS query in Diff extraction to a Conduit call

Summary

Ref T9319. Ref T2783. This won't currently work in a future environment where daemons and repositories are not on the same host. Send it over Conduit instead.

Test Plan

Used bin/differential attach-commit rX Dy to force attachment, saw valid content pull over Conduit.

Diff Detail

Repository

rP Phabricator

Branch

diff3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9991
Build 12075: Run Core Tests
Build 12074: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36163.Jan 8 2016, 1:53 PM

epriestley retitled this revision from to Convert a low-level VCS query in Diff extraction to a Conduit call.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9319: Accessing image file in Diffusion must not generate error (unhandled exception), T2783: Make working-copy operations service-oriented.

chad accepted this revision.Jan 8 2016, 4:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 8 2016, 4:31 PM

Closed by commit rPda3963b009ce: Convert a low-level VCS query in Diff extraction to a Conduit call (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2016, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

engine/

DifferentialDiffExtractionEngine.php

26 lines

Diff 36163

View Options

src/applications/differential/engine/DifferentialDiffExtractionEngine.php

Convert a low-level VCS query in Diff extraction to a Conduit callClosedPublicActions