Page MenuHomePhabricator

Make mundane performance improvements to Diffusion browse views
ClosedPublic

Authored by epriestley on Jan 7 2016, 1:56 AM.
Tags
None
Referenced Files
F13149055: D14963.diff
Sat, May 4, 6:19 AM
Unknown Object (File)
Fri, May 3, 2:48 PM
Unknown Object (File)
Fri, May 3, 2:47 PM
Unknown Object (File)
Fri, May 3, 2:47 PM
Unknown Object (File)
Fri, May 3, 2:47 PM
Unknown Object (File)
Fri, May 3, 2:46 PM
Unknown Object (File)
Fri, May 3, 10:42 AM
Unknown Object (File)
Wed, May 1, 3:10 PM
Subscribers
None

Details

Summary

Ref T2450. This reorganizes code to improve performance.

Mostly, there are a lot of things which are unique per commit (author name, links, short name, etc), but we were rendering them for every line.

This often meant we'd render the same author's name thousands of times. This is slower than rendering it only once.

In 99% of interfaces this doesn't matter, but blame is weird and it's significant on big files.

Test Plan

Locally, __phutil_library_map__.php now has costs of roughly:

  • 550ms for main content (from 650ms before the patch).
  • 1,500ms for blame content (frrom 1,800ms before the patch).

So this isn't huge, is a decent ~20%-ish performance gain for shuffling some stuff around.

Diff Detail

Repository
rP Phabricator
Branch
blame6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9978
Build 12058: Run Core Tests
Build 12057: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make mundane performance improvements to Diffusion browse views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This is the wrong diff, one sec..

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2016, 2:26 AM
epriestley edited edge metadata.
  • Fix a bug with line link generation.
This revision was automatically updated to reflect the committed changes.