Page MenuHomePhabricator
Differential D14958

Drive blame generation through `diffusion.blame`
ClosedPublic
Actions

Authored by epriestley on Jan 6 2016, 2:20 PM.
Tags
None
Referenced Files
F19888693: D14958.id36140.diff
Tue, Mar 24, 3:46 AM
F19844181: D14958.id36137.diff
Mar 12 2026, 5:12 AM
F19812410: D14958.diff
Mar 4 2026, 4:54 AM
F19691446: D14958.id36140.diff
Feb 10 2026, 2:35 AM
F19676501: D14958.id36137.diff
Feb 8 2026, 12:02 PM
F19287526: D14958.diff
Dec 23 2025, 6:54 AM
F19153009: D14958.id.diff
Dec 11 2025, 6:46 AM
F18798625: D14958.id36137.diff
Oct 17 2025, 7:19 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2450: Build a blame cache
T9319: Accessing image file in Diffusion must not generate error (unhandled exception)
Commits
Restricted Diffusion Commit
rP9728c65e9358: Drive blame generation through `diffusion.blame`
Summary

Ref T2450. Ref T9319. This is still a bit messy, but not quite so bad as it was: instead of using a single call to get both blame information and file content, use diffusion.blame for blame information.

This will make optimizations to both blame and file content easier.

Test Plan

Viewed a bunch of blame (color on/off, blame on/off).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36137.Jan 6 2016, 2:20 PM
epriestley retitled this revision from to Drive blame generation through `diffusion.blame`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T9319: Accessing image file in Diffusion must not generate error (unhandled exception), T2450: Build a blame cache.
chad accepted this revision.Jan 6 2016, 3:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 3:13 PM
Closed by commit rP9728c65e9358: Drive blame generation through `diffusion.blame` (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2016, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36140

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/query/__tests__/DiffusionGitFileContentQueryTestCase.php

Loading...
View Options

src/applications/diffusion/query/filecontent/DiffusionFileContentQuery.php

Loading...
View Options

src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php

Loading...
View Options

src/applications/diffusion/query/filecontent/DiffusionMercurialFileContentQuery.php

Loading...
View Options

src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
Phabricator · Built by Phacility