Paths

Table of Contentst

Differential D14958

Drive blame generation through `diffusion.blame`
ClosedPublic
Actions

Authored by epriestley on Jan 6 2016, 2:20 PM.

Tags

None

Referenced Files

	F20361888: D14958.id36137.diff
	Fri, Jun 12, 9:52 AM

	Unknown Object (File)
	Mar 24 2026, 3:46 AM

	Unknown Object (File)
	Mar 12 2026, 5:12 AM

	Unknown Object (File)
	Mar 4 2026, 4:54 AM

	Unknown Object (File)
	Feb 10 2026, 2:35 AM

	Unknown Object (File)
	Feb 8 2026, 12:02 PM

	Unknown Object (File)
	Dec 23 2025, 6:54 AM

	Unknown Object (File)
	Dec 11 2025, 6:46 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T2450: Build a blame cache
T9319: Accessing image file in Diffusion must not generate error (unhandled exception)

Commits

Restricted Diffusion Commit
rP9728c65e9358: Drive blame generation through `diffusion.blame`

Summary

Ref T2450. Ref T9319. This is still a bit messy, but not quite so bad as it was: instead of using a single call to get both blame information and file content, use diffusion.blame for blame information.

This will make optimizations to both blame and file content easier.

Test Plan

Viewed a bunch of blame (color on/off, blame on/off).

Diff Detail

Repository

Branch

blame2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/diffusion/DiffusionLintSaveRunner.php:261	XHP16	TODO Comment
Advice	src/applications/diffusion/controller/DiffusionBrowseController.php:1760	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 9962
Build 12033: Run Core Tests
Build 12032: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36137.Jan 6 2016, 2:20 PM

epriestley retitled this revision from to Drive blame generation through `diffusion.blame`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9319: Accessing image file in Diffusion must not generate error (unhandled exception), T2450: Build a blame cache.

chad accepted this revision.Jan 6 2016, 3:13 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2016, 3:13 PM

Closed by commit rP9728c65e9358: Drive blame generation through `diffusion.blame` (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2016, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

DiffusionLintSaveRunner.php

6 lines

conduit/

DiffusionFileContentQueryConduitAPIMethod.php

16 lines

controller/

DiffusionBrowseController.php

204 lines

query/

__tests__/

DiffusionGitFileContentQueryTestCase.php

filecontent/

DiffusionFileContentQuery.php

116 lines

DiffusionGitFileContentQuery.php

39 lines

DiffusionMercurialFileContentQuery.php

58 lines

DiffusionSvnFileContentQuery.php

15 lines

repository/

storage/

PhabricatorRepositoryCommit.php

26 lines

Diff 36137

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...

src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php

Loading...

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...

src/applications/diffusion/query/tests/DiffusionGitFileContentQueryTestCase.php

Loading...

src/applications/diffusion/query/filecontent/DiffusionFileContentQuery.php

Loading...

src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php

Loading...

src/applications/diffusion/query/filecontent/DiffusionMercurialFileContentQuery.php

Loading...

src/applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...