Page MenuHomePhabricator
Differential D14947

Modernize most somewhat-weird Diffusion controllers
ClosedPublic
Actions

Authored by epriestley on Jan 5 2016, 7:02 PM.
Tags
None
Referenced Files
F15199886: D14947.diff
Sun, Feb 23, 10:50 AM
Unknown Object (File)
Sun, Feb 9, 12:20 AM
Unknown Object (File)
Sun, Feb 9, 12:20 AM
Unknown Object (File)
Sun, Feb 9, 12:20 AM
Unknown Object (File)
Tue, Jan 28, 11:24 PM
Unknown Object (File)
Tue, Jan 28, 12:42 AM
Unknown Object (File)
Jan 24 2025, 10:55 AM
Unknown Object (File)
Jan 24 2025, 10:55 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP3cbc239bc640: Modernize most somewhat-weird Diffusion controllers
Summary

Ref T4245. This gets everything else except serving HTTP requests (complicated) and lint (quite weird).

Test Plan
  • Viewed a diff.
  • Viewed externals.
  • Viewed history table to see last modified.
  • Did path completion and validation in Owners.
  • Did tree path search in Diffusion.
  • Viewed a repository.
  • Created a new repository.
  • Looked up symbols.

Diff Detail

Repository
rP Phabricator
Branch
call8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9934
Build 11992: Run Core Tests
Build 11991: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36109.Jan 5 2016, 7:02 PM
epriestley retitled this revision from to Modernize most somewhat-weird Diffusion controllers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 5 2016, 7:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2016, 7:12 PM
Closed by commit rP3cbc239bc640: Modernize most somewhat-weird Diffusion controllers (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36109

View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionExternalController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLastModifiedController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionPathCompleteController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionPathTreeController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionPathValidateController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionSymbolController.php

Loading...
Phabricator · Built by Phacility