Page MenuHomePhabricator
Differential D14944

Modernize more Diffusion controllers
ClosedPublic
Actions

Authored by epriestley on Jan 5 2016, 4:41 PM.
Tags
None
Referenced Files
F15485251: D14944.id36120.diff
Wed, Apr 9, 10:53 PM
F15477815: D14944.id36097.diff
Mon, Apr 7, 5:56 PM
F15476226: D14944.diff
Mon, Apr 7, 4:44 AM
F15475029: D14944.id.diff
Sun, Apr 6, 2:52 PM
F15472848: D14944.diff
Sat, Apr 5, 5:02 PM
F15460261: D14944.id36120.diff
Mon, Mar 31, 9:17 PM
F15460260: D14944.id.diff
Mon, Mar 31, 9:17 PM
F15460258: D14944.id36097.diff
Mon, Mar 31, 9:17 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP2bfc5ff92ec2: Modernize more Diffusion controllers
Summary

Ref T4245. Standardize how context is read, minor updates / modernizations / consistency tweaks.

Test Plan
  • Viewed a change.
  • Viewed brnaches.
  • Edited a commit.
  • Viewed tags.
  • Viewed history.
  • Added, edited and deleted a mirror.
  • Viewed push events.
  • Viewed a particular event.
  • Viewed ref disambiguation.
  • Viewed repository list.
  • Ran automation test.

Diff Detail

Repository
rP Phabricator
Branch
call6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9921
Build 11975: Run Core Tests
Build 11974: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36097.Jan 5 2016, 4:41 PM
epriestley retitled this revision from to Modernize more Diffusion controllers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 5 2016, 6:22 PM
chad edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Jan 5 2016, 6:22 PM
chad accepted this revision.Jan 5 2016, 6:22 PM

itsawesome

Closed by commit rP2bfc5ff92ec2: Modernize more Diffusion controllers (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 10:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36097

View Options

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitBranchesController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitTagsController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionMirrorDeleteController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionMirrorEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionPushEventViewController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionPushLogListController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRefTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryListController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryTestAutomationController.php

Loading...
Phabricator · Built by Phacility