Page MenuHomePhabricator
Differential D14937

Move generateDiffusionURI() into PhabricatorRepository
ClosedPublic
Actions

Authored by epriestley on Jan 4 2016, 4:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 9:14 AM
Unknown Object (File)
Wed, Jan 29, 10:02 PM
Unknown Object (File)
Tue, Jan 28, 12:40 AM
Unknown Object (File)
Fri, Jan 24, 10:54 AM
Unknown Object (File)
Fri, Jan 24, 10:54 AM
Unknown Object (File)
Fri, Jan 24, 10:54 AM
Unknown Object (File)
Tue, Jan 21, 11:16 AM
Unknown Object (File)
Sat, Jan 18, 4:37 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP07e2596aa14c: Move generateDiffusionURI() into PhabricatorRepository
Summary

Ref T4245. This further reduces the reliance on callsigns in Diffusion.

Test Plan
  • Pretty reasonable test coverage already exists.
  • Browsed repository list, browse view, history view, content view, change view, commit view, tag view, branch view of repositories.

Diff Detail

Repository
rP Phabricator
Branch
call1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9911
Build 11956: Run Core Tests
Build 11955: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36087.Jan 4 2016, 4:14 PM
epriestley retitled this revision from to Move generateDiffusionURI() into PhabricatorRepository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 4 2016, 4:41 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2016, 4:41 PM
Closed by commit rP07e2596aa14c: Move generateDiffusionURI() into PhabricatorRepository (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 12:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
16 lines
request/
173 lines
__tests__/
19 lines
owners/
controller/
3 lines
repository/
query/
3 lines
storage/
135 lines

Diff 36087

View Options

src/applications/diffusion/controller/DiffusionExternalController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/diffusion/request/__tests__/DiffusionURITestCase.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility