Page MenuHomePhabricator

Reduce the total number of calls to getCallsign()
ClosedPublic

Authored by epriestley on Jan 2 2016, 1:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 3:49 PM
Unknown Object (File)
Sun, Feb 9, 12:18 AM
Unknown Object (File)
Sun, Feb 9, 12:18 AM
Unknown Object (File)
Sun, Feb 9, 12:18 AM
Unknown Object (File)
Feb 1 2025, 12:38 AM
Unknown Object (File)
Jan 30 2025, 1:19 PM
Unknown Object (File)
Jan 30 2025, 8:02 AM
Unknown Object (File)
Jan 28 2025, 12:38 AM
Subscribers
None

Details

Summary

Ref T4245. Before doing any hard work here, we can dramatically reduce the number of things that make calls to getCallsign() to make navigating things easier. Almost all of them only care about a monogram, URI, or display name.

Test Plan
  • Searched for r uniquename in jump nav.
  • Ran bin/repository reparse --change rXXXyyyyy --trace, observed query against bad commit table.
  • Ran bin/search index rXXXyyyy --trace --force, observed proper title when indexing commit.
  • Browed repository list, saw proper rXXX and appropriate link targets.
  • Mentioned rXXX in Remarkup, got a link to the right place.

Diff Detail

Repository
rP Phabricator
Branch
callsign1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9881
Build 11911: Run Core Tests
Build 11910: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Reduce the total number of calls to getCallsign().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 2:11 AM
This revision was automatically updated to reflect the committed changes.