Page MenuHomePhabricator
Differential D14911

Give IconSetControl a meaningful disabled state
ClosedPublic
Actions

Authored by epriestley on Dec 30 2015, 11:26 AM.
Tags
None
Referenced Files
F15473046: D14911.id.diff
Sat, Apr 5, 7:18 PM
F15469917: D14911.diff
Fri, Apr 4, 6:03 PM
F15469482: D14911.id36036.diff
Fri, Apr 4, 1:35 PM
F15420916: D14911.id36036.diff
Fri, Mar 21, 6:59 PM
F15401083: D14911.id36045.diff
Mon, Mar 17, 3:37 PM
F15383640: D14911.id.diff
Fri, Mar 14, 5:27 PM
F15284826: D14911.diff
Mar 4 2025, 10:36 AM
Unknown Object (File)
Mar 3 2025, 11:24 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10004: ApplicationEditor Errata
Commits
Restricted Diffusion Commit
rP972788b8b5df: Give IconSetControl a meaningful disabled state
Summary

Ref T10004. This control doesn't disable visually or behaviorally, e.g. when locked in an EditEngine configuration.

Test Plan
  • Locked field for Projects.
  • Reviewed form in EditEngine.
  • Created/edited a project.
  • Swapped default.

Diff Detail

Repository
rP Phabricator
Branch
proj1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9859
Build 11877: Run Core Tests
Build 11876: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36036.Dec 30 2015, 11:26 AM
epriestley retitled this revision from to Give IconSetControl a meaningful disabled state.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10004: ApplicationEditor Errata.
chad accepted this revision.Dec 30 2015, 5:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2015, 5:08 PM
Closed by commit rP972788b8b5df: Give IconSetControl a meaningful disabled state (authored by epriestley, committed by epriestley). · Explain WhyDec 30 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
view/
form/
control/
13 lines
webroot/
rsrc/
js/
core/
9 lines

Diff 36036

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/PHUIFormIconSetControl.php

Loading...
View Options

webroot/rsrc/js/core/behavior-choose-control.js

Loading...
Phabricator · Built by Phacility