Fix bad query on PhameHome with no Blogs
ClosedPublic
Actions

Authored by chad on Dec 29 2015, 7:11 AM.

Tags

None

Referenced Files

	F15487266: D14908.id36032.diff
	Thu, Apr 10, 12:43 PM

	F15484740: D14908.id36029.diff
	Wed, Apr 9, 7:50 PM

	F15482284: D14908.id.diff
	Wed, Apr 9, 4:08 AM

	F15481576: D14908.diff
	Tue, Apr 8, 9:56 PM

	F15477568: D14908.id36029.diff
	Mon, Apr 7, 4:16 PM

	F15476847: D14908.id36032.diff
	Mon, Apr 7, 9:50 AM

	F15475902: D14908.id36029.diff
	Mon, Apr 7, 1:03 AM

	F15474211: D14908.id36032.diff
	Sun, Apr 6, 6:28 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP7732f9c03c84: Fix bad query on PhameHome with no Blogs

Summary

We're checking for drafts even though we already know there are no blogs, just skip the query.

Test Plan

trucate phame_blogs; See proper blank state.

Diff Detail

Repository

rP Phabricator

Branch

new-blog (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9852
Build 11867: Run Core Tests
Build 11866: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36029.Dec 29 2015, 7:11 AM

chad retitled this revision from to Fix bad query on PhameHome with no Blogs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 29 2015, 7:11 AM

epriestley accepted this revision.Dec 29 2015, 11:08 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2015, 11:08 AM

Closed by commit rP7732f9c03c84: Fix bad query on PhameHome with no Blogs (authored by chad, committed by chad). · Explain WhyDec 29 2015, 3:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameHomeController.php

2 lines

Diff 36029

View Options

src/applications/phame/controller/PhameHomeController.php

Fix bad query on PhameHome with no BlogsClosedPublicActions