Page MenuHomePhabricator
Differential D14908

Fix bad query on PhameHome with no Blogs
ClosedPublic
Actions

Authored by chad on Dec 29 2015, 7:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:16 PM
Unknown Object (File)
Wed, Apr 24, 10:22 PM
Unknown Object (File)
Tue, Apr 16, 5:06 PM
Unknown Object (File)
Thu, Apr 11, 11:27 AM
Unknown Object (File)
Sat, Apr 6, 5:37 AM
Unknown Object (File)
Fri, Apr 5, 3:13 PM
Unknown Object (File)
Tue, Apr 2, 5:52 AM
Unknown Object (File)
Apr 1 2024, 4:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP7732f9c03c84: Fix bad query on PhameHome with no Blogs
Summary

We're checking for drafts even though we already know there are no blogs, just skip the query.

Test Plan

trucate phame_blogs; See proper blank state.

Diff Detail

Repository
rP Phabricator
Branch
new-blog (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9852
Build 11867: Run Core Tests
Build 11866: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36029.Dec 29 2015, 7:11 AM
chad retitled this revision from to Fix bad query on PhameHome with no Blogs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 29 2015, 7:11 AM
epriestley accepted this revision.Dec 29 2015, 11:08 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2015, 11:08 AM
Closed by commit rP7732f9c03c84: Fix bad query on PhameHome with no Blogs (authored by chad, committed by chad). · Explain WhyDec 29 2015, 3:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
2 lines

Diff 36029

View Options

src/applications/phame/controller/PhameHomeController.php

Loading...
Phabricator · Built by Phacility