Page MenuHomePhabricator
Differential D14879

Keep hovercards mostly on screen
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 5:54 AM
Unknown Object (File)
Thu, Dec 5, 12:05 AM
Unknown Object (File)
Sat, Nov 30, 8:04 PM
Unknown Object (File)
Nov 27 2024, 2:40 AM
Unknown Object (File)
Nov 25 2024, 2:06 PM
Unknown Object (File)
Nov 22 2024, 10:06 PM
Unknown Object (File)
Nov 22 2024, 5:10 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by avivey.

Details

Reviewers
chad
Maniphest Tasks
T8980: Make hovecards activate for standard handle lists
Commits
Restricted Diffusion Commit
rPe88dbbe1b1bc: Keep hovercards mostly on screen
Summary

Ref T8980.

Test Plan

Screen Shot 2015-12-24 at 11.59.28 AM.png (1×1 px, 211 KB)

Diff Detail

Repository
rP Phabricator
Branch
hlist3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9783
Build 11761: Run Core Tests
Build 11760: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35964.Dec 24 2015, 8:00 PM
epriestley retitled this revision from to Keep hovercards mostly on screen.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8980: Make hovecards activate for standard handle lists.
chad accepted this revision.Dec 24 2015, 8:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 8:07 PM
epriestley updated this revision to Diff 35965.Dec 24 2015, 8:09 PM
epriestley edited edge metadata.
  • BONUS! Also keep it from going off the right side of the screen.
chad added a comment.Dec 24 2015, 8:09 PM

(y)

epriestley added a comment.Dec 24 2015, 8:10 PM

Yell if you figure out how to trick it into going offscreen. I think I got 'em all but maybe I missed something.

Closed by commit rPe88dbbe1b1bc: Keep hovercards mostly on screen (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 8:18 PM
This revision was automatically updated to reflect the committed changes.
avivey awarded a token.Dec 24 2015, 10:22 PM
avivey mentioned this in T10687: jx-tooltip does whatever it feels like.Mar 31 2016, 1:34 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
js/
core/
23 lines
28 lines

Diff 35964

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/Hovercard.js

Loading...
View Options

webroot/rsrc/js/core/behavior-hovercard.js

Loading...
Phabricator · Built by Phacility