Page MenuHomePhabricator

Modernize Hovercard implementation
ClosedPublic

Authored by epriestley on Dec 24 2015, 7:46 PM.
Tags
None
Referenced Files
F15453707: D14878.diff
Sat, Mar 29, 1:42 PM
F15450826: D14878.id35967.diff
Fri, Mar 28, 6:30 PM
F15446163: D14878.id.diff
Thu, Mar 27, 5:26 PM
F15445928: D14878.id35963.diff
Thu, Mar 27, 4:35 PM
F15442677: D14878.diff
Wed, Mar 26, 11:57 PM
F15432254: D14878.id.diff
Mon, Mar 24, 5:04 PM
F15427721: D14878.id35963.diff
Sun, Mar 23, 3:47 PM
F15418304: D14878.id35967.diff
Thu, Mar 20, 10:24 PM
Subscribers
None

Details

Summary

Ref T8980. Move away from events to EngineExtensions.

This also simplifies hovercards a bit:

  • Removes tasks from revision cards.
  • Removes blockers/blocked from task cards.
  • Removes "Send Message" from user cards.

These mostly felt cluttery to me. Open to arguments to retain them. I think we can make better use of the space, though (e.g., flags, projects + board columns).

Test Plan
  • Viewed people, task, revision, commit and project hovercards.

Screen Shot 2015-12-24 at 11.40.37 AM.png (1×1 px, 193 KB)

Screen Shot 2015-12-24 at 11.40.45 AM.png (1×1 px, 206 KB)

Diff Detail

Repository
rP Phabricator
Branch
hlist2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9782
Build 11759: Run Core Tests
Build 11758: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Hovercard implementation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 8:07 PM
This revision was automatically updated to reflect the committed changes.