Page MenuHomePhabricator

Modernize Hovercard implementation
ClosedPublic

Authored by epriestley on Dec 24 2015, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 12:34 AM
Unknown Object (File)
Fri, Jan 24, 10:49 AM
Unknown Object (File)
Tue, Jan 21, 10:24 AM
Unknown Object (File)
Dec 30 2024, 2:30 AM
Unknown Object (File)
Dec 28 2024, 4:30 PM
Unknown Object (File)
Dec 24 2024, 9:01 PM
Unknown Object (File)
Dec 20 2024, 1:40 AM
Unknown Object (File)
Dec 10 2024, 11:25 PM
Subscribers
None

Details

Summary

Ref T8980. Move away from events to EngineExtensions.

This also simplifies hovercards a bit:

  • Removes tasks from revision cards.
  • Removes blockers/blocked from task cards.
  • Removes "Send Message" from user cards.

These mostly felt cluttery to me. Open to arguments to retain them. I think we can make better use of the space, though (e.g., flags, projects + board columns).

Test Plan
  • Viewed people, task, revision, commit and project hovercards.

Screen Shot 2015-12-24 at 11.40.37 AM.png (1×1 px, 193 KB)

Screen Shot 2015-12-24 at 11.40.45 AM.png (1×1 px, 206 KB)

Diff Detail

Repository
rP Phabricator
Branch
hlist2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9782
Build 11759: Run Core Tests
Build 11758: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Hovercard implementation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 8:07 PM
This revision was automatically updated to reflect the committed changes.