Page MenuHomePhabricator

Modernize Hovercard implementation
ClosedPublic

Authored by epriestley on Dec 24 2015, 7:46 PM.
Tags
None
Referenced Files
F19903207: D14878.diff
Mon, Mar 30, 10:59 PM
F19617302: D14878.id35963.diff
Feb 4 2026, 5:32 AM
F19530630: D14878.id35967.diff
Jan 19 2026, 11:22 PM
F19530628: D14878.id35967.diff
Jan 19 2026, 11:22 PM
F19527156: D14878.id35967.diff
Jan 18 2026, 11:22 PM
F18834577: D14878.diff
Oct 26 2025, 9:34 AM
F18829823: D14878.id.diff
Oct 25 2025, 1:25 AM
F18819176: D14878.id.diff
Oct 22 2025, 4:45 AM
Subscribers
None

Details

Summary

Ref T8980. Move away from events to EngineExtensions.

This also simplifies hovercards a bit:

  • Removes tasks from revision cards.
  • Removes blockers/blocked from task cards.
  • Removes "Send Message" from user cards.

These mostly felt cluttery to me. Open to arguments to retain them. I think we can make better use of the space, though (e.g., flags, projects + board columns).

Test Plan
  • Viewed people, task, revision, commit and project hovercards.

Screen Shot 2015-12-24 at 11.40.37 AM.png (1×1 px, 193 KB)

Screen Shot 2015-12-24 at 11.40.45 AM.png (1×1 px, 206 KB)

Diff Detail

Repository
rP Phabricator
Branch
hlist2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9782
Build 11759: Run Core Tests
Build 11758: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize Hovercard implementation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 8:07 PM
This revision was automatically updated to reflect the committed changes.