Page MenuHomePhabricator

Implement a "Project Members" object policy rule
ClosedPublic

Authored by epriestley on Dec 24 2015, 1:19 AM.
Tags
None
Referenced Files
F19826302: D14869.id35956.diff
Sun, Mar 8, 7:06 PM
F19825954: D14869.id35944.diff
Sun, Mar 8, 4:05 PM
F19825090: D14869.id35956.diff
Sun, Mar 8, 7:28 AM
F19824837: D14869.id35944.diff
Sun, Mar 8, 4:20 AM
F19807130: D14869.id.diff
Tue, Mar 3, 2:06 AM
F19661214: D14869.diff
Feb 7 2026, 6:06 AM
F19526385: D14869.diff
Jan 18 2026, 4:15 PM
F19526371: D14869.diff
Jan 18 2026, 4:07 PM
Subscribers
None

Details

Summary

Fixes T9019. Pretty much ripped from D14467. I added the "policy hint" stuff so that you can create a project with this policy immediately.

I really dislike how the "hint" code works, but we almost never need to use it and the badness feels fairly well-contained.

Also pick up a quick feedback fix from D14863.

Test Plan
  • Added test coverage, got it to pass.
  • Created a project with "Visible To: Project Members".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a "Project Members" object policy rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:27 PM
This revision was automatically updated to reflect the committed changes.