Page MenuHomePhabricator
Differential D14869

Implement a "Project Members" object policy rule
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 1:19 AM.
Tags
None
Referenced Files
F15418731: D14869.id.diff
Fri, Mar 21, 1:07 AM
F15389947: D14869.id.diff
Sat, Mar 15, 5:47 AM
F15384994: D14869.diff
Fri, Mar 14, 9:22 PM
F15333076: D14869.id35944.diff
Fri, Mar 7, 11:43 PM
F15333075: D14869.id.diff
Fri, Mar 7, 11:43 PM
F15333074: D14869.id35956.diff
Fri, Mar 7, 11:43 PM
F15333052: D14869.diff
Fri, Mar 7, 11:28 PM
F15327274: D14869.diff
Fri, Mar 7, 4:30 AM
View All Files
Subscribers
None

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9019: Create a "Project Members" object policy for Projects
Commits
Restricted Diffusion Commit
rP1c572d1da51f: Implement a "Project Members" object policy rule
Summary

Fixes T9019. Pretty much ripped from D14467. I added the "policy hint" stuff so that you can create a project with this policy immediately.

I really dislike how the "hint" code works, but we almost never need to use it and the badness feels fairly well-contained.

Also pick up a quick feedback fix from D14863.

Test Plan
  • Added test coverage, got it to pass.
  • Created a project with "Visible To: Project Members".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35944.Dec 24 2015, 1:19 AM
epriestley retitled this revision from to Implement a "Project Members" object policy rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad.
epriestley mentioned this in D14467: Add a "members of project" policy rule.Dec 24 2015, 1:21 AM
epriestley updated this object.Dec 24 2015, 11:13 AM
epriestley added a task: T9019: Create a "Project Members" object policy for Projects.
chad accepted this revision.Dec 24 2015, 3:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 3:27 PM
Closed by commit rP1c572d1da51f: Implement a "Project Members" object policy rule (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 4:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35956

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

Loading...
View Options

src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/policyrule/PhabricatorProjectMembersPolicyRule.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
Phabricator · Built by Phacility