Lock daemon configuration
ClosedPublic
Actions

Authored by joshuaspence on Dec 24 2015, 12:01 AM.

Tags

None

Referenced Files

	F14029053: D14867.id35942.diff
	Fri, Nov 8, 7:06 PM

	F14014148: D14867.id35942.diff
	Sat, Nov 2, 11:29 PM

	F14013556: D14867.id35942.diff
	Sat, Nov 2, 7:43 AM

	F13992410: D14867.id.diff
	Tue, Oct 22, 4:23 PM

	F13961602: D14867.id35941.diff
	Tue, Oct 15, 5:40 AM

	Unknown Object (File)
	Sep 19 2024, 9:07 PM

	Unknown Object (File)
	Sep 9 2024, 2:45 PM

	Unknown Object (File)
	Sep 4 2024, 7:48 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP8bacb3da23d9: Lock daemon configuration

Summary

I feel like the daemon configuration should be locked from editing from the web UI, given that much of it won't work unless the daemons are restarted anyway.

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9760
Build 11725: Run Core Tests
Build 11724: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35941.Dec 24 2015, 12:01 AM

joshuaspence retitled this revision from to Lock daemon configuration.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 24 2015, 12:01 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 24 2015, 12:13 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 24 2015, 12:13 AM

Closed by commit rP8bacb3da23d9: Lock daemon configuration (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 24 2015, 12:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorPHDConfigOptions.php

5 lines

Diff 35941

View Options

src/applications/config/option/PhabricatorPHDConfigOptions.php

Lock daemon configurationClosedPublicActions