Page MenuHomePhabricator
Differential D14855

Put inline previews in remarkup textareas
ClosedPublic
Actions

Authored by epriestley on Dec 22 2015, 8:09 PM.
Tags
None
Referenced Files
F15414449: D14855.diff
Thu, Mar 20, 12:38 AM
F15409859: D14855.id35912.diff
Wed, Mar 19, 5:44 AM
F15408627: D14855.id35910.diff
Wed, Mar 19, 12:18 AM
F15399918: D14855.id35910.diff
Mon, Mar 17, 8:33 AM
F15399250: D14855.id.diff
Mon, Mar 17, 3:33 AM
F15396463: D14855.diff
Sun, Mar 16, 2:29 PM
F15390040: D14855.id35910.diff
Sat, Mar 15, 5:51 AM
F15383476: D14855.diff
Fri, Mar 14, 4:50 PM
View All Files
Subscribers
• gracelz
Tokens
"Love" token, awarded by OCram.

Details

Reviewers
chad
Maniphest Tasks
T3967: Build a 2-up preview mode into the fullscreen Remarkup editor
Commits
Restricted Diffusion Commit
rPf5ff10fe283d: Put inline previews in remarkup textareas
Summary

Ref T3967. This gives us a reasonable baseline for doing remarkup previews inline in all contexts, and works in weird/constrained context including:

  • inline comments;
  • conpherence; and
  • custom fields.

It would be nicer to go beyond this in contexts like Phame posts, but this is a start, at least.

Test Plan

Screen Shot 2015-12-22 at 12.01.05 PM.png (1×1 px, 193 KB)

Screen Shot 2015-12-22 at 12.01.11 PM.png (1×1 px, 194 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35910.Dec 22 2015, 8:09 PM
epriestley retitled this revision from to Put inline previews in remarkup textareas.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.
Herald edited edge metadata. · View Herald TranscriptDec 22 2015, 8:09 PM
chad accepted this revision.Dec 22 2015, 8:17 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 8:17 PM
Closed by commit rPf5ff10fe283d: Put inline previews in remarkup textareas (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 8:18 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Dec 22 2015, 8:18 PM

Feel free to counterdiff me if that blue is too intense.

• gracelz added a subscriber: • gracelz.Dec 23 2015, 8:34 AM

ddd

src/applications/transactions/application/PhabricatorTransactionsApplication.php
36

llllddddd

OCram awarded a token.Dec 23 2015, 9:00 AM
epriestley mentioned this in T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.Jun 28 2017, 4:21 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
src/
2 lines
applications/
transactions/
application/
2 lines
controller/
25 lines
view/
form/
control/
23 lines
webroot/
rsrc/
css/
core/
33 lines
js/
core/
111 lines

Diff 35912

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/transactions/application/PhabricatorTransactionsApplication.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionRemarkupPreviewController.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility