Page MenuHomePhabricator
Differential D14836

Remove TYPE_SEARCH_DIDUPDATEINDEX event
ClosedPublic
Actions

Authored by epriestley on Dec 21 2015, 2:58 PM.
Tags
None
Referenced Files
F15560189: D14836.id35864.diff
Tue, Apr 29, 1:22 PM
F15558392: D14836.id35891.diff
Tue, Apr 29, 2:35 AM
F15545191: D14836.id.diff
Sat, Apr 26, 9:29 AM
F15544470: D14836.diff
Sat, Apr 26, 5:13 AM
F15541013: D14836.diff
Fri, Apr 25, 10:13 AM
F15523199: D14836.diff
Sun, Apr 20, 11:49 PM
F15398196: D14836.id.diff
Mar 16 2025, 11:45 PM
F15386519: D14836.id.diff
Mar 15 2025, 12:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles)
Commits
Restricted Diffusion Commit
rPaab1574e336e: Remove TYPE_SEARCH_DIDUPDATEINDEX event
Summary

Ref T9979. This event had one weird callsite and no known third-party callers. It can be done more cleanly as an extension, now.

This index is used to allow us to "Group By: Project" in Maniphest without joining into the Projects database.

Test Plan
  • Ran a query with "Group By: Project" in Maniphest.
  • Renamed project "Apples" to "Zebras".
  • Reloaded page.
  • UI properly moved "Zebras" tasks to the bottom of the list.

Diff Detail

Repository
rP Phabricator
Branch
index3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9683
Build 11609: Run Core Tests
Build 11608: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35864.Dec 21 2015, 2:58 PM
epriestley retitled this revision from to Remove TYPE_SEARCH_DIDUPDATEINDEX event.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
chad accepted this revision.Dec 21 2015, 3:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:49 PM
Closed by commit rPaab1574e336e: Remove TYPE_SEARCH_DIDUPDATEINDEX event (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 1:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
maniphest/
application/
1 line
engineextension/
25 lines
event/
search/
index/
17 lines
docs/
user/
userguide/
35 lines
infrastructure/
events/
constant/
2 lines

Diff 35864

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/maniphest/engineextension/ManiphestProjectNameFulltextEngineExtension.php

Loading...
View Options

src/applications/maniphest/event/ManiphestNameIndexEventListener.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
View Options

src/docs/user/userguide/events.diviner

Loading...
View Options

src/infrastructure/events/constant/PhabricatorEventType.php

Loading...
Phabricator · Built by Phacility