Page MenuHomePhabricator
Differential D14836

Remove TYPE_SEARCH_DIDUPDATEINDEX event
ClosedPublic
Actions

Authored by epriestley on Dec 21 2015, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 15, 11:17 PM
Unknown Object (File)
Sat, May 31, 2:51 AM
Unknown Object (File)
Wed, May 28, 1:02 PM
Unknown Object (File)
Tue, May 27, 12:33 PM
Unknown Object (File)
Sun, May 25, 6:46 AM
Unknown Object (File)
May 10 2025, 3:42 PM
Unknown Object (File)
Apr 29 2025, 1:22 PM
Unknown Object (File)
Apr 29 2025, 2:35 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles)
Commits
Restricted Diffusion Commit
rPaab1574e336e: Remove TYPE_SEARCH_DIDUPDATEINDEX event
Summary

Ref T9979. This event had one weird callsite and no known third-party callers. It can be done more cleanly as an extension, now.

This index is used to allow us to "Group By: Project" in Maniphest without joining into the Projects database.

Test Plan
  • Ran a query with "Group By: Project" in Maniphest.
  • Renamed project "Apples" to "Zebras".
  • Reloaded page.
  • UI properly moved "Zebras" tasks to the bottom of the list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35864.Dec 21 2015, 2:58 PM
epriestley retitled this revision from to Remove TYPE_SEARCH_DIDUPDATEINDEX event.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).
chad accepted this revision.Dec 21 2015, 3:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:49 PM
Closed by commit rPaab1574e336e: Remove TYPE_SEARCH_DIDUPDATEINDEX event (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 1:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
maniphest/
application/
1 line
engineextension/
25 lines
event/
search/
index/
17 lines
docs/
user/
userguide/
35 lines
infrastructure/
events/
constant/
2 lines

Diff 35891

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/maniphest/engineextension/ManiphestProjectNameFulltextEngineExtension.php

Loading...
View Options

src/applications/maniphest/event/ManiphestNameIndexEventListener.php

Loading...
View Options

src/applications/search/index/PhabricatorSearchDocumentIndexer.php

Loading...
View Options

src/docs/user/userguide/events.diviner

Loading...
View Options

src/infrastructure/events/constant/PhabricatorEventType.php

Loading...
Phabricator · Built by Phacility