Page MenuHomePhabricator
Differential D14833

Basic NUX blank states
ClosedPublic
Actions

Authored by chad on Dec 20 2015, 5:28 PM.
Tags
None
Referenced Files
F14351815: D14833.diff
Thu, Dec 19, 10:33 AM
F14351609: D14833.id35866.diff
Thu, Dec 19, 8:40 AM
Unknown Object (File)
Fri, Dec 13, 10:09 PM
Unknown Object (File)
Fri, Dec 13, 10:50 AM
Unknown Object (File)
Fri, Dec 13, 2:48 AM
Unknown Object (File)
Wed, Dec 11, 9:35 PM
Unknown Object (File)
Sun, Dec 8, 8:26 PM
Unknown Object (File)
Sat, Dec 7, 7:06 PM
View All Files
Subscribers
johnny-bit
Korvin
Tokens
"Love" token, awarded by hach-que.

Details

Reviewers
epriestley
Maniphest Tasks
T10032: Improve individual NUX states (application level)
Commits
Restricted Diffusion Commit
rPc6f3a03209b6: Basic NUX blank states
Summary

Implement in Badges

Test Plan

Test with nux=true.

pasted_file (493×1 px, 82 KB)

Diff Detail

Repository
rP Phabricator
Branch
nux (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/badges/query/PhabricatorBadgesSearchEngine.php:150XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9680
Build 11603: Run Core Tests
Build 11602: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35861.Dec 20 2015, 5:28 PM
chad retitled this revision from to Basic NUX blank states.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 20 2015, 5:28 PM
chad edited the test plan for this revision. (Show Details)Dec 20 2015, 5:28 PM
johnny-bit added a subscriber: johnny-bit.Dec 20 2015, 11:11 PM

itsawesome

hach-que awarded a token.Dec 21 2015, 11:09 AM
epriestley accepted this revision.Dec 21 2015, 12:41 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesSearchEngine.php
150

You should be able to grab the icon with $this->getApplication()->getFontIcon().

This revision is now accepted and ready to land.Dec 21 2015, 12:41 PM
chad updated this revision to Diff 35866.Dec 21 2015, 3:36 PM
chad edited edge metadata.
  • use variables more
Closed by commit rPc6f3a03209b6: Basic NUX blank states (authored by chad, committed by chad). · Explain WhyDec 21 2015, 3:39 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T10032: Improve individual NUX states (application level).Dec 21 2015, 9:07 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
2 lines
src/
2 lines
applications/
badges/
query/
19 lines
search/
engine/
10 lines
view/
phui/
95 lines
webroot/
rsrc/
css/
phui/
29 lines

Diff 35861

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/view/phui/PHUIBigInfoView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-big-info-view.css

Loading...
Phabricator · Built by Phacility