Page MenuHomePhabricator

Basic NUX blank states
ClosedPublic

Authored by chad on Dec 20 2015, 5:28 PM.

Details

Summary

Implement in Badges

Test Plan

Test with nux=true.

Diff Detail

Repository
rP Phabricator
Branch
nux (branched from master)
Lint
Lint OK
SeverityLocationCodeMessage
Advicesrc/applications/badges/query/PhabricatorBadgesSearchEngine.php:150XHP16TODO Comment
Unit
Unit Tests OK
Build Status
Buildable 9680
Build 11603: Run Core Tests
Build 11602: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35861.Dec 20 2015, 5:28 PM
chad retitled this revision from to Basic NUX blank states.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad edited the test plan for this revision. (Show Details)Dec 20 2015, 5:28 PM
epriestley accepted this revision.Dec 21 2015, 12:41 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesSearchEngine.php
150

You should be able to grab the icon with $this->getApplication()->getFontIcon().

This revision is now accepted and ready to land.Dec 21 2015, 12:41 PM
chad updated this revision to Diff 35866.Dec 21 2015, 3:36 PM
chad edited edge metadata.
  • use variables more
This revision was automatically updated to reflect the committed changes.