Page MenuHomePhabricator
Differential D14802

Update PhamePost to EditEngine
ClosedPublic
Actions

Authored by chad on Dec 16 2015, 9:14 PM.
Tags
None
Referenced Files
F14055620: D14802.diff
Sat, Nov 16, 1:58 PM
F14044917: D14802.id36006.diff
Tue, Nov 12, 10:50 PM
F14041225: D14802.diff
Mon, Nov 11, 4:51 PM
F14040975: D14802.id35790.diff
Mon, Nov 11, 2:49 PM
F14026553: D14802.diff
Fri, Nov 8, 1:39 AM
F14026016: D14802.id35790.diff
Thu, Nov 7, 9:57 PM
F13992276: D14802.id36006.diff
Tue, Oct 22, 3:34 PM
F13987449: D14802.id36007.diff
Mon, Oct 21, 9:31 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP10ed33052361: Update PhamePost to EditEngine
Summary

Allows create and edit workflows through EditEngine. Not sure I did the 'blog' stuff correct.

Test Plan

Create a new post, edit a post, move a post.

Diff Detail

Repository
rP Phabricator
Branch
phame-post-edit-engine (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9607
Build 11495: Run Core Tests
Build 11494: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35790.Dec 16 2015, 9:14 PM
chad retitled this revision from to Update PhamePost to EditEngine.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 16 2015, 9:14 PM
chad added a comment.Dec 16 2015, 9:16 PM

I should note this need to wait on a document preview as well.

epriestley edited edge metadata.Dec 16 2015, 9:39 PM

I think the blog stuff is OK. We might be able to clean up the part where it loads it eventually, but that seems fine for now.

Let me take a look at hooking up previews on top of this.

src/applications/phame/controller/post/PhamePostEditController.php
34

We should have a if (!$blog) { return new Aphront404Response(); } bit here.

chad updated this revision to Diff 35791.Dec 16 2015, 9:43 PM
chad edited edge metadata.
  • !blog
epriestley mentioned this in T3967: Build a 2-up preview mode into the fullscreen Remarkup editor.Dec 22 2015, 1:34 PM

I'm tentatively going to see if I can move forward with T3967 to provide previews.

epriestley accepted this revision.EditedDec 27 2015, 4:18 PM
epriestley edited edge metadata.

You should be able to use setPreviewPanel() to get the previews working now after D14887, let me know if you run into issues.

This revision is now accepted and ready to land.Dec 27 2015, 4:18 PM
chad updated this revision to Diff 36005.Dec 28 2015, 1:24 AM
chad edited edge metadata.
  • !blog
  • update to new edit stuff
src/applications/phame/editor/PhamePostEditEngine.php
35

This causes issues if actually trying to create a new blog post form, since $blog is required for a new post. Not sure what the correct fix is.

epriestley added a comment.Dec 28 2015, 1:27 AM

I think you can probably do something like this:

$viewer = $this->getViewer();

if ($this->blog) {
  $blog = $this->blog;
} else {
  $blog = PhameBlog::initializeNewBlog($viewer);
}

return PhamePost::initializePost($viewer, $blog);

Basically, just make a dummy empty blog for the meta-edit-form-edit stuff.

chad updated this revision to Diff 36006.Dec 28 2015, 1:39 AM
  • rough in a fake blog
Closed by commit rP10ed33052361: Update PhamePost to EditEngine (authored by chad, committed by chad). · Explain WhyDec 28 2015, 1:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phame/
controller/
post/
178 lines
editor/
86 lines

Diff 35790

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/editor/PhamePostEditEngine.php

Loading...
Phabricator · Built by Phacility