Paths

Table of Contentst

Differential D14796

Improve Conduit type handling for `*.edit` endpoints
ClosedPublic
Actions

Authored by epriestley on Dec 16 2015, 1:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 5:07 PM

	Unknown Object (File)
	Sat, Dec 14, 4:12 AM

	Unknown Object (File)
	Tue, Dec 10, 9:17 PM

	Unknown Object (File)
	Sun, Dec 1, 7:13 AM

	Unknown Object (File)
	Thu, Nov 28, 12:47 PM

	Unknown Object (File)
	Wed, Nov 27, 3:01 AM

	Unknown Object (File)
	Sat, Nov 23, 6:47 AM

	Unknown Object (File)
	Nov 19 2024, 3:00 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9964: Fill in Conduit support infrastructure for ApplicationEditor changes

Commits

Restricted Diffusion Commit
rP161ebad56d7a: Improve Conduit type handling for `*.edit` endpoints

Summary

Ref T9964. Three goals here:

Make it easier to supply Conduit documentation.
Make automatic documentation for *.edit endpoints more complete, particularly for custom fields.
Allow type resolution via Conduit types, so you can pass ["alincoln"] to "subscribers" instead of needing to use PHIDs.

Test Plan

Viewed and used all search and edit endpoints, including custom fields.
Used parameter type resolution to set subscribers to user "dog" instead of "PHID-USER-whatever".
Viewed HTTP parameter documentation.

Diff Detail

Repository

Branch

ee7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9594
Build 11475: Run Core Tests
Build 11474: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35777.Dec 16 2015, 1:52 PM

epriestley retitled this revision from to Improve Conduit type handling for `*.edit` endpoints.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

chad accepted this revision.Dec 16 2015, 4:34 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 16 2015, 4:34 PM

Closed by commit rP161ebad56d7a: Improve Conduit type handling for `*.edit` endpoints (authored by epriestley, committed by epriestley). · Explain WhyDec 16 2015, 4:45 PM

This revision was automatically updated to reflect the committed changes.

avivey added a subscriber: avivey.May 10 2016, 1:37 AM

avivey added inline comments.

src/applications/conduit/parametertype/ConduitWildParameterType.php
5	Does this intentionally extends `ListParameterType`, or is it a typo (Doesn't support maps/objects...)?

Typo, a few things improperly extended List via copy/pasta errors. I think most of them have been cleaned up, but they're unintentional unless the subtype actually makes sense as a list subtype.

D15881 for last of these fixes, I think.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

conduit/

parametertype/

ConduitPHIDParameterType.php

35 lines

ConduitWildParameterType.php

22 lines

maniphest/

editor/

ManiphestEditEngine.php

15 lines

owners/

editor/

PhabricatorOwnersPackageEditEngine.php

5 lines

paste/

editor/

PhabricatorPasteEditEngine.php

34 lines

policy/

editor/

PhabricatorPolicyEditEngineExtension.php

9 lines

project/

engineextension/

PhabricatorProjectsEditEngineExtension.php

18 lines

subscriptions/

engineextension/

PhabricatorSubscriptionsEditEngineExtension.php

17 lines

transactions/

editengine/

PhabricatorEditEngine.php

35 lines

PhabricatorEditEngineAPIMethod.php

17 lines

editengineextension/

PhabricatorCommentEditEngineExtension.php

4 lines

PhabricatorEditEngineExtension.php

7 lines

editfield/

PhabricatorCommentEditField.php

8 lines

PhabricatorConduitEditField.php

4 lines

PhabricatorEditField.php

131 lines

PhabricatorInstructionsEditField.php

4 lines

PhabricatorPHIDListEditField.php

31 lines

PhabricatorPolicyEditField.php

5 lines

PhabricatorProjectsEditField.php

4 lines

PhabricatorRemarkupEditField.php

4 lines

PhabricatorSelectEditField.php

4 lines

PhabricatorSpaceEditField.php

4 lines

PhabricatorSubscribersEditField.php

4 lines

PhabricatorTextAreaEditField.php

4 lines

PhabricatorTextEditField.php

4 lines

PhabricatorUsersEditField.php

4 lines

edittype/

PhabricatorCommentEditType.php

8 lines

PhabricatorEdgeEditType.php

9 lines

PhabricatorEditType.php

119 lines

PhabricatorPHIDListEditType.php

13 lines

PhabricatorSimpleEditType.php

23 lines

infrastructure/

customfield/

editor/

PhabricatorCustomFieldEditField.php

38 lines

PhabricatorCustomFieldEditType.php

15 lines

field/

PhabricatorCustomField.php

16 lines

standard/

PhabricatorStandardCustomFieldBool.php

5 lines

PhabricatorStandardCustomFieldDate.php

4 lines

PhabricatorStandardCustomFieldInt.php

4 lines

PhabricatorStandardCustomFieldLink.php

5 lines

PhabricatorStandardCustomFieldSelect.php

5 lines

PhabricatorStandardCustomFieldUsers.php

4 lines

Diff 35777

src/__phutil_library_map__.php

Loading...

src/applications/conduit/parametertype/ConduitPHIDParameterType.php

Loading...

src/applications/conduit/parametertype/ConduitWildParameterType.php

Loading...

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...

src/applications/paste/editor/PhabricatorPasteEditEngine.php

Loading...

src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php

Loading...

src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php

Loading...

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngineAPIMethod.php

Loading...

src/applications/transactions/editengineextension/PhabricatorCommentEditEngineExtension.php

Loading...

src/applications/transactions/editengineextension/PhabricatorEditEngineExtension.php

Loading...

src/applications/transactions/editfield/PhabricatorCommentEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorConduitEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorInstructionsEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorPHIDListEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorPolicyEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorProjectsEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorRemarkupEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorSelectEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorSpaceEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorSubscribersEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorTextAreaEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorTextEditField.php

Loading...

src/applications/transactions/editfield/PhabricatorUsersEditField.php

Loading...

src/applications/transactions/edittype/PhabricatorCommentEditType.php

Loading...

src/applications/transactions/edittype/PhabricatorEdgeEditType.php

Loading...

src/applications/transactions/edittype/PhabricatorEditType.php

Loading...

src/applications/transactions/edittype/PhabricatorPHIDListEditType.php

Loading...

src/applications/transactions/edittype/PhabricatorSimpleEditType.php

Loading...

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditType.php

Loading...

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php

Loading...