Page MenuHomePhabricator

Have "limit=1" tokenizers replace tokens instead of disabling "Browse"
ClosedPublic

Authored by epriestley on Dec 14 2015, 10:53 PM.
Tags
None
Referenced Files
F15445203: D14785.id35754.diff
Thu, Mar 27, 12:50 PM
F15443247: D14785.id35748.diff
Thu, Mar 27, 3:17 AM
F15441394: D14785.id.diff
Wed, Mar 26, 5:57 PM
F15437086: D14785.diff
Tue, Mar 25, 5:28 PM
F15431524: D14785.diff
Mon, Mar 24, 12:51 PM
F15386199: D14785.id35754.diff
Sat, Mar 15, 12:10 AM
F15381507: D14785.id35748.diff
Fri, Mar 14, 7:59 AM
Unknown Object (File)
Mar 3 2025, 2:55 PM
Subscribers
None

Details

Summary

Fixes T9984. When a tokenizer only allows one selection (like "Task Owner:" or "Land Onto Branch:"), keep the browse button active but have it replace values.

Also, have "Create Subtask" default to the system default status, so subtasks of closed tasks are not also closed.

Test Plan
  • Browsed an empty limit=1 tokenizer.
  • Replaced a full limit=1 tokenizer.
  • Browsed an empty no-limit tokenizer.
  • Browsed more tokens into the no-limit tokenizer.
  • Typed some tokens normally.
  • Created a subtask of a closed task.

Diff Detail

Repository
rP Phabricator
Branch
clog8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9566
Build 11435: Run Core Tests
Build 11434: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Have "limit=1" tokenizers replace tokens instead of disabling "Browse".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2015, 11:18 PM
This revision was automatically updated to reflect the committed changes.