Differential D14753

Read profile images from Google OAuth correctly
ClosedPublic
Actions

Authored by epriestley on Dec 12 2015, 3:52 PM.

Details

Reviewers

chad

Maniphest Tasks

T9972: Profile image from Google not being picked up

Commits

rPHU4a09be9ffd4a: Read profile images from Google OAuth correctly

Summary

Fixes T9972. Not sure if this was always a bug or the API changed. There's also a "url" we can use now.

Test Plan

Refreshed a Google OAuth account link, got a profile picture:

Screen Shot 2015-12-12 at 7.50.22 AM.png (139×199 px, 20 KB)

Diff Detail

Repository

rPHU libphutil

Branch

gauth1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9496
Build 11323: Run Core Tests
Build 11322: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35676.Dec 12 2015, 3:52 PM

epriestley retitled this revision from to Read profile images from Google OAuth correctly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9972: Profile image from Google not being picked up.

chad accepted this revision.Dec 12 2015, 3:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 12 2015, 3:52 PM

Closed by commit rPHU4a09be9ffd4a: Read profile images from Google OAuth correctly (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2015, 3:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilGoogleAuthAdapter.php

15 lines

Diff 35676

View Options

src/auth/PhutilGoogleAuthAdapter.php

Read profile images from Google OAuth correctlyClosedPublicActions