Page MenuHomePhabricator

In `arc diff`, try to guess where a change should land
ClosedPublic

Authored by epriestley on Dec 10 2015, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 2:44 AM
Unknown Object (File)
Wed, Jan 29, 2:41 PM
Unknown Object (File)
Tue, Jan 28, 9:11 PM
Unknown Object (File)
Sun, Jan 26, 7:46 AM
Unknown Object (File)
Fri, Jan 24, 10:26 AM
Unknown Object (File)
Tue, Jan 21, 12:51 PM
Unknown Object (File)
Tue, Jan 21, 4:09 AM
Unknown Object (File)
Sat, Jan 18, 7:03 AM
Subscribers
None

Details

Summary

Ref T9952. Ref T3462. My primary goal is to improve prefilling of the "Onto Branch:" field in the "Land Revision" dialog.

When uploading a diff with arc diff, add a property with some information about which branch to target. In particular:

  • If the local branch tracks an upstream branch (or tracks something which tracks something which tracks the upstream), target that.
  • If not, but "arc.land.onto.default" is set, target that.

This doesn't try to guess in other cases, since they're more involved. I'll add some context about this in T3462.

I don't love using "diff properties" for this, but it doesn't make cleaning them up any harder since we already use it for other stuff which isn't going away (lint/unit excuses).

Test Plan
  • Added some var_dump() and used arc diff --only to generate diffs.
  • Saw upstream tracking and config-based rules generate reasonable values and submit them.

Diff Detail

Repository
rARC Arcanist
Branch
ontobranch (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9460
Build 11270: Run Core Tests
Build 11269: arc lint + arc unit