Page MenuHomePhabricator
Differential D14737

When `arc` has sent target branch data up after D14736, use it in the UI and "Land Revision"
ClosedPublic
Actions

Authored by epriestley on Dec 10 2015, 11:06 PM.
Tags
None
Referenced Files
F14337944: D14737.id35643.diff
Wed, Dec 18, 6:19 PM
Unknown Object (File)
Thu, Dec 12, 5:33 AM
Unknown Object (File)
Fri, Dec 6, 4:19 AM
Unknown Object (File)
Tue, Dec 3, 11:05 AM
Unknown Object (File)
Sun, Dec 1, 7:08 AM
Unknown Object (File)
Mon, Nov 25, 2:42 PM
Unknown Object (File)
Sat, Nov 23, 12:20 AM
Unknown Object (File)
Fri, Nov 22, 7:58 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T3462: In Differential, expose "featurename (branched from master)" via Conduit
T9952: Let "Land Revision" target branches other than master
Commits
Restricted Diffusion Commit
rP954cd4b1b6e7: When `arc` has sent target branch data up after D14736, use it in the UI and…
Summary

Ref T9952. Ref T3462. After D14736, if we have information about the target/"onto" branch, use it in the UI:

  • Show "feature (branched from master)" instead of "feature".
  • Default "Land Revision" to hit the correct branch.
Test Plan
  • Branched from test with branch tracking.
  • Diffed.
  • Saw "feature (branched from test)" in UI.
  • Saw "test" fill as default in "Land Revision", despite the repository having a different default branch.

Screen Shot 2015-12-10 at 3.03.36 PM.png (384×670 px, 37 KB)

Screen Shot 2015-12-10 at 3.03.02 PM.png (171×420 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35643.Dec 10 2015, 11:06 PM
epriestley retitled this revision from to When `arc` has sent target branch data up after D14736, use it in the UI and "Land Revision".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T9952: Let "Land Revision" target branches other than master, T3462: In Differential, expose "featurename (branched from master)" via Conduit.
epriestley mentioned this in T3462: In Differential, expose "featurename (branched from master)" via Conduit.Dec 10 2015, 11:15 PM
chad accepted this revision.Dec 10 2015, 11:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 11:23 PM
Closed by commit rP954cd4b1b6e7: When `arc` has sent target branch data up after D14736, use it in the UI and… (authored by epriestley, committed by epriestley). · Explain WhyDec 10 2015, 11:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
18 lines
customfield/
10 lines
storage/
43 lines

Diff 35645

View Options

src/applications/differential/controller/DifferentialRevisionOperationController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialBranchField.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
Phabricator · Built by Phacility