Page MenuHomePhabricator
Differential D14730

Filter archived Badges from UI
ClosedPublic
Actions

Authored by chad on Dec 10 2015, 6:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 2:47 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Fri, Jan 24, 10:24 AM
Unknown Object (File)
Thu, Jan 23, 10:33 PM
Unknown Object (File)
Thu, Jan 23, 10:21 PM
Unknown Object (File)
Thu, Jan 23, 7:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9944: Figure out what happens when you archive a badge
Commits
Restricted Diffusion Commit
rP6985643f5809: Filter archived Badges from UI
Summary

If you archive a badge, remove it's presence in the main Phabricator UI. These are still accessible from /badges/ for properity. Ref T9944

Test Plan

Archive a badge, weep uncontrollably.

Diff Detail

Repository
rP Phabricator
Branch
archive-badge
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9442
Build 11246: Run Core Tests
Build 11245: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35622.Dec 10 2015, 6:24 PM
chad retitled this revision from to Filter archived Badges from UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9944: Figure out what happens when you archive a badge.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 10 2015, 6:24 PM
epriestley accepted this revision.Dec 10 2015, 6:35 PM
epriestley edited edge metadata.

Maybe add some text to the "Archive" dialog about this too?

This revision is now accepted and ready to land.Dec 10 2015, 6:35 PM
Closed by commit rP6985643f5809: Filter archived Badges from UI (authored by chad, committed by chad). · Explain WhyDec 10 2015, 6:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
1 line
event/
1 line
view/
phui/
1 line

Diff 35622

View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/event/PhabricatorPeopleHovercardEventListener.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
Phabricator · Built by Phacility