Page MenuHomePhabricator
Differential D14727

Add PhabricatorBadgeArchiveController
ClosedPublic
Actions

Authored by chad on Dec 9 2015, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 5:59 AM
Unknown Object (File)
Fri, Jan 24, 8:58 PM
Unknown Object (File)
Fri, Jan 24, 10:23 AM
Unknown Object (File)
Fri, Jan 24, 10:23 AM
Unknown Object (File)
Fri, Jan 24, 10:23 AM
Unknown Object (File)
Fri, Jan 24, 10:23 AM
Unknown Object (File)
Fri, Jan 24, 10:23 AM
Unknown Object (File)
Sun, Jan 19, 4:00 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9414: Method for archiving a things are inconsistent occasionally, sometimes
Commits
Restricted Diffusion Commit
rPdec69e21b378: Add PhabricatorBadgeArchiveController
Summary

Allows archive and activate on badges from action list. Ref T9414

Test Plan

Archive, Activate, New, Edit

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35614.Dec 9 2015, 9:15 PM
chad retitled this revision from to Add PhabricatorBadgeArchiveController.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9414: Method for archiving a things are inconsistent occasionally, sometimes.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 9 2015, 9:15 PM
epriestley accepted this revision.Dec 9 2015, 9:21 PM
epriestley edited edge metadata.

Maybe don't show archived badges on profile/timeline? Or if we already don't, mention that effect in the dialog?

src/applications/badges/controller/PhabricatorBadgesArchiveController.php
56–58

he he he

This revision is now accepted and ready to land.Dec 9 2015, 9:21 PM
chad added a comment.Dec 9 2015, 9:24 PM

I'll file a task to track that.

chad updated this revision to Diff 35616.Dec 9 2015, 9:27 PM
chad edited edge metadata.
  • clean up language
Closed by commit rPdec69e21b378: Add PhabricatorBadgeArchiveController (authored by chad, committed by chad). · Explain WhyDec 9 2015, 9:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35617

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/application/PhabricatorBadgesApplication.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesArchiveController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesEditController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/badges/phid/PhabricatorBadgesPHIDType.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...
Phabricator · Built by Phacility