Page MenuHomePhabricator
Differential D14727

Add PhabricatorBadgeArchiveController
ClosedPublic
Actions

Authored by chad on Dec 9 2015, 9:15 PM.
Tags
None
Referenced Files
F13268901: D14727.diff
Wed, May 29, 5:30 AM
F13266579: D14727.id.diff
Tue, May 28, 3:48 PM
F13254408: D14727.diff
Sat, May 25, 3:23 AM
F13249555: D14727.id35617.diff
Fri, May 24, 9:25 AM
F13249554: D14727.id35616.diff
Fri, May 24, 9:25 AM
F13249553: D14727.id35614.diff
Fri, May 24, 9:25 AM
F13249552: D14727.id.diff
Fri, May 24, 9:25 AM
F13249551: D14727.diff
Fri, May 24, 9:25 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9414: Method for archiving a things are inconsistent occasionally, sometimes
Commits
Restricted Diffusion Commit
rPdec69e21b378: Add PhabricatorBadgeArchiveController
Summary

Allows archive and activate on badges from action list. Ref T9414

Test Plan

Archive, Activate, New, Edit

Diff Detail

Repository
rP Phabricator
Branch
badges-archive
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9434
Build 11234: Run Core Tests
Build 11233: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35614.Dec 9 2015, 9:15 PM
chad retitled this revision from to Add PhabricatorBadgeArchiveController.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9414: Method for archiving a things are inconsistent occasionally, sometimes.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 9 2015, 9:15 PM
epriestley accepted this revision.Dec 9 2015, 9:21 PM
epriestley edited edge metadata.

Maybe don't show archived badges on profile/timeline? Or if we already don't, mention that effect in the dialog?

src/applications/badges/controller/PhabricatorBadgesArchiveController.php
55–57

he he he

This revision is now accepted and ready to land.Dec 9 2015, 9:21 PM
chad added a comment.Dec 9 2015, 9:24 PM

I'll file a task to track that.

chad updated this revision to Diff 35616.Dec 9 2015, 9:27 PM
chad edited edge metadata.
  • clean up language
Closed by commit rPdec69e21b378: Add PhabricatorBadgeArchiveController (authored by chad, committed by chad). · Explain WhyDec 9 2015, 9:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35614

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/application/PhabricatorBadgesApplication.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesArchiveController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesEditController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/badges/phid/PhabricatorBadgesPHIDType.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...
Phabricator · Built by Phacility