Differential D14691

Clean up some EditEngine policy issues
ClosedPublic
Actions

Authored by epriestley on Dec 7 2015, 6:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rP5caee3521eaa: Clean up some EditEngine policy issues

Summary

Ref T9908.

You should not need edit permission on a task in order to comment on it.
At least for now, ignore any customization in Conduit and Stacked Actions. These UIs always use the full edit form as it's written in the application.

Test Plan

Verified a non-editor can now comment on tasks they can see.
Verified a user still can't use an edit form they can't see.

Diff Detail

Repository

rP Phabricator

Branch

ex12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9351
Build 11109: Run Core Tests
Build 11108: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35534.Dec 7 2015, 6:37 PM

epriestley retitled this revision from to Clean up some EditEngine policy issues.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

chad accepted this revision.Dec 7 2015, 7:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 7 2015, 7:03 PM

Closed by commit rP5caee3521eaa: Clean up some EditEngine policy issues (authored by epriestley, committed by epriestley). · Explain WhyDec 7 2015, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

106 lines

query/

PhabricatorEditEngineConfigurationQuery.php

12 lines

Diff 35534

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php