Page MenuHomePhabricator
Differential D14683

Add a "Change priority to: ..." Herald action
ClosedPublic
Actions

Authored by epriestley on Dec 5 2015, 7:17 PM.
Tags
None
Referenced Files
F14055549: D14683.diff
Sat, Nov 16, 1:10 PM
F14053040: D14683.id35513.diff
Fri, Nov 15, 12:18 PM
F14047775: D14683.id35513.diff
Thu, Nov 14, 5:14 AM
F14042745: D14683.diff
Tue, Nov 12, 5:48 AM
F14027034: D14683.diff
Fri, Nov 8, 4:42 AM
F14006251: D14683.id35511.diff
Mon, Oct 28, 4:09 AM
F13995752: D14683.id.diff
Wed, Oct 23, 3:12 PM
F13977943: D14683.diff
Oct 18 2024, 8:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions
Commits
Restricted Diffusion Commit
rPf22dc9d47a5d: Add a "Change priority to: ..." Herald action
Summary

Ref T7848. This is a companion to "Change status to: ...".

(I'm pretty sure the only reason I didn't originally write these was the tokenizer bug in D14682, I just forgot about it).

This is basically a copy/paste of the "status" action.

Test Plan
  • Wrote a rule to change task priorities.
  • Edited a task.
  • Saw rule fire properly.
  • Tokens also stick around correctly.

Diff Detail

Repository
rP Phabricator
Branch
ex6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9328
Build 11077: Run Core Tests
Build 11076: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35511.Dec 5 2015, 7:17 PM
epriestley retitled this revision from to Add a "Change priority to: ..." Herald action.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.
chad accepted this revision.Dec 5 2015, 7:19 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2015, 7:19 PM
Closed by commit rPf22dc9d47a5d: Add a "Change priority to: ..." Herald action (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 7:20 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed.Dec 16 2015, 6:27 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
maniphest/
herald/
87 lines

Diff 35511

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskPriorityHeraldAction.php

Loading...
Phabricator · Built by Phacility