Page MenuHomePhabricator
Differential D14665

Make "Quote" work with EditEngine in Paste and Maniphest
ClosedPublic
Actions

Authored by epriestley on Dec 4 2015, 3:13 PM.
Tags
None
Referenced Files
F14843561: D14665.id.diff
Sun, Feb 2, 7:51 AM
Unknown Object (File)
Fri, Jan 24, 10:16 AM
Unknown Object (File)
Fri, Jan 24, 7:10 AM
Unknown Object (File)
Thu, Jan 23, 12:12 PM
Unknown Object (File)
Tue, Jan 21, 9:55 AM
Unknown Object (File)
Sat, Jan 18, 2:49 AM
Unknown Object (File)
Thu, Jan 16, 10:46 AM
Unknown Object (File)
Dec 26 2024, 6:05 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9132: Build an ApplicationEditor abstraction
Commits
Restricted Diffusion Commit
rPdd0b09a610b3: Make "Quote" work with EditEngine in Paste and Maniphest
Summary

Ref T9132. This makes the "Quote" action on comments work properly in these applications.

Test Plan

Quoted text in each application.

Diff Detail

Repository
rP Phabricator
Branch
ee37
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9282
Build 11012: Run Core Tests
Build 11011: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35471.Dec 4 2015, 3:13 PM
epriestley retitled this revision from to Make "Quote" work with EditEngine in Paste and Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9132: Build an ApplicationEditor abstraction.
chad accepted this revision.Dec 4 2015, 3:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2015, 3:20 PM
Closed by commit rPdd0b09a610b3: Make "Quote" work with EditEngine in Paste and Maniphest (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9077: Some applications don't support the "Quote" action on comments properly.Dec 5 2015, 9:21 PM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
3 lines
paste/
controller/
6 lines
transactions/
view/
11 lines

Diff 35471

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
Phabricator · Built by Phacility