Page MenuHomePhabricator
Differential D14656

Fix Phame Post creation time
ClosedPublic
Actions

Authored by chad on Dec 3 2015, 9:40 PM.
Tags
None
Referenced Files
F19087242: D14656.diff
Dec 3 2025, 12:07 AM
F19060065: D14656.diff
Nov 29 2025, 7:52 AM
F18849539: D14656.id.diff
Oct 30 2025, 10:34 AM
F18845481: D14656.diff
Oct 29 2025, 12:19 PM
F18841378: D14656.id35454.diff
Oct 28 2025, 8:36 AM
F18756248: D14656.id35453.diff
Oct 5 2025, 10:26 AM
F18745169: D14656.diff
Oct 3 2025, 5:34 AM
F18696591: D14656.diff
Sep 27 2025, 8:04 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9897: Unbeta Feedback on Phame
T9360: Unbeta Phame
Commits
Restricted Diffusion Commit
rP39903769f063: Fix Phame Post creation time
Summary

I spent way to long to arrive at this solution. Ref T9360

Test Plan

Publish a new post, see time, unpublish post, see draft. Start a new post, wait 10 minutes, publish, see "now".

Diff Detail

Repository
rP Phabricator
Branch
pub-time-phame
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9264
Build 10985: Run Core Tests
Build 10984: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35453.Dec 3 2015, 9:40 PM
chad retitled this revision from to Fix Phame Post creation time.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 3 2015, 9:40 PM
epriestley accepted this revision.Dec 3 2015, 9:42 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/storage/PhamePost.php
37

For consistency, prefer PhabricatorTime::getNow() (which allows unit tests to force the "current time" to some specific known time).

This revision is now accepted and ready to land.Dec 3 2015, 9:42 PM
chad updated this object.Dec 3 2015, 9:42 PM
chad edited edge metadata.
chad added a task: T9360: Unbeta Phame.
Closed by commit rP39903769f063: Fix Phame Post creation time (authored by chad, committed by chad). · Explain WhyDec 3 2015, 9:43 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T9897: Unbeta Feedback on Phame.Dec 3 2015, 9:44 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
post/
2 lines
storage/
2 lines

Diff 35453

View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility