Page MenuHomePhabricator

Fix Phame Post creation time
ClosedPublic

Authored by chad on Dec 3 2015, 9:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 4:47 AM
Unknown Object (File)
Thu, Mar 7, 4:47 AM
Unknown Object (File)
Thu, Mar 7, 4:02 AM
Unknown Object (File)
Thu, Mar 7, 4:01 AM
Unknown Object (File)
Feb 15 2024, 6:48 AM
Unknown Object (File)
Feb 13 2024, 12:29 PM
Unknown Object (File)
Feb 9 2024, 1:03 AM
Unknown Object (File)
Feb 3 2024, 7:32 AM
Subscribers

Details

Summary

I spent way to long to arrive at this solution. Ref T9360

Test Plan

Publish a new post, see time, unpublish post, see draft. Start a new post, wait 10 minutes, publish, see "now".

Diff Detail

Repository
rP Phabricator
Branch
pub-time-phame
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9264
Build 10985: Run Core Tests
Build 10984: arc lint + arc unit

Event Timeline

chad retitled this revision from to Fix Phame Post creation time.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/storage/PhamePost.php
37

For consistency, prefer PhabricatorTime::getNow() (which allows unit tests to force the "current time" to some specific known time).

This revision is now accepted and ready to land.Dec 3 2015, 9:42 PM
chad edited edge metadata.
chad added a task: T9360: Unbeta Phame.
This revision was automatically updated to reflect the committed changes.