Page MenuHomePhabricator
Differential D14649

Remove `asp_tags` from XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 10:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:56 AM
Unknown Object (File)
Sun, Feb 9, 5:34 AM
Unknown Object (File)
Sat, Feb 8, 11:58 PM
Unknown Object (File)
Thu, Feb 6, 8:42 AM
Unknown Object (File)
Sat, Jan 25, 5:26 AM
Unknown Object (File)
Fri, Jan 24, 10:14 AM
Unknown Object (File)
Tue, Jan 21, 8:46 PM
Unknown Object (File)
Sat, Jan 18, 7:23 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9380454298b0: Remove `asp_tags` from XHPAST
Summary

This is hardcoded to false anyway.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9245
Build 10956: Run Core Tests
Build 10955: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35434.Dec 2 2015, 10:44 PM
joshuaspence retitled this revision from to Remove `asp_tags` from XHPAST.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 10:44 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence mentioned this in D14537: Tidying of XHPAST.Dec 2 2015, 10:46 PM
epriestley accepted this revision.Dec 5 2015, 12:25 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2015, 12:25 AM
Closed by commit rPHU9380454298b0: Remove `asp_tags` from XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 7 2015, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
2 lines
support/
xhpast/
2 lines
22 lines
2 lines
1542 lines
3 lines

Diff 35434

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility