Page MenuHomePhabricator
Differential D14645

Remove some unused variables and functions from XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:45 PM.
Tags
None
Referenced Files
F14012559: D14645.diff
Fri, Nov 1, 2:50 PM
F14002914: D14645.id35428.diff
Fri, Oct 25, 11:59 PM
F13987416: D14645.diff
Mon, Oct 21, 9:21 AM
F13978827: D14645.diff
Sat, Oct 19, 1:10 AM
F13978817: D14645.id.diff
Sat, Oct 19, 1:07 AM
F13978815: D14645.id35428.diff
Sat, Oct 19, 1:06 AM
F13978805: D14645.id35435.diff
Sat, Oct 19, 1:03 AM
F13959200: D14645.id35435.diff
Mon, Oct 14, 6:15 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU6eff51516b3b: Remove some unused variables and functions from XHPAST
Summary

Minor cleaning up of XHPAST source code.

Test Plan

Ranunit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9239
Build 10945: Run Core Tests
Build 10944: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35428.Dec 2 2015, 9:45 PM
joshuaspence retitled this revision from to Remove some unused variables and functions from XHPAST.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:45 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 2 2015, 9:46 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2015, 9:46 PM
Closed by commit rPHU6eff51516b3b: Remove some unused variables and functions from XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 10:46 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D14537: Tidying of XHPAST.Dec 2 2015, 10:46 PM

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
2 lines
support/
xhpast/
19 lines
5 lines
1931 lines
3 lines

Diff 35428

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility