Paths

Table of Contentst

Differential D14643

Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:33 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCae3c2cb0e172: Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`

Summary

Binary integers (such as 0b1) were added to PHP 5.4 and cannot be used in earlier versions.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35425.Dec 2 2015, 9:33 PM

joshuaspence retitled this revision from to Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:33 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 2 2015, 9:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2015, 9:33 PM

Closed by commit rARCae3c2cb0e172: Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule` (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 9:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

10 lines

__tests__/

php-compatibility/

php54-features.lint-test

3 lines

Diff 35427

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/php-compatibility/php54-features.lint-test

Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`ClosedPublicActions