Paths

Table of Contentst

Differential D14644

Add a "binary integer casing" linter rule
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC3c193984da6f: Add a "binary integer casing" linter rule

Summary

Adds a linter rule which ensures that binary integers are written in lowercase (i.e. 0b1 instead of 0B1).

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9237
Build 10942: Run Core Tests
Build 10941: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	484 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	62 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	22 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 298 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35426.Dec 2 2015, 9:38 PM

joshuaspence retitled this revision from to Add a "binary integer casing" linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:38 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 2 2015, 9:46 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2015, 9:46 PM

Closed by commit rARC3c193984da6f: Add a "binary integer casing" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 10:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistBinaryNumericScalarCasingXHPASTLinterRule.php

49 lines

ArcanistHexadecimalNumericScalarCasingXHPASTLinterRule.php

6 lines

__tests__/

ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

11 lines

binary-numeric-scalar-casing/

binary.lint-test

5 lines

Diff 35426

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistBinaryNumericScalarCasingXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistHexadecimalNumericScalarCasingXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/binary-numeric-scalar-casing/binary.lint-test

Add a "binary integer casing" linter ruleClosedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 35426

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistBinaryNumericScalarCasingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistHexadecimalNumericScalarCasingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/binary-numeric-scalar-casing/binary.lint-test

Add a "binary integer casing" linter rule
ClosedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/binary-numeric-scalar-casing/binary.lint-test