Page MenuHomePhabricator
Differential D14644

Add a "binary integer casing" linter rule
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 4:43 AM
Unknown Object (File)
Fri, Nov 22, 7:20 AM
Unknown Object (File)
Wed, Nov 20, 10:26 PM
Unknown Object (File)
Wed, Nov 20, 10:04 PM
Unknown Object (File)
Mon, Nov 18, 8:54 PM
Unknown Object (File)
Thu, Nov 14, 4:28 AM
Unknown Object (File)
Tue, Nov 12, 12:25 PM
Unknown Object (File)
Oct 23 2024, 3:54 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC3c193984da6f: Add a "binary integer casing" linter rule
Summary

Adds a linter rule which ensures that binary integers are written in lowercase (i.e. 0b1 instead of 0B1).

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9237
Build 10942: Run Core Tests
Build 10941: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
484 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
62 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
24 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
22 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
10 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 298 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35426.Dec 2 2015, 9:38 PM
joshuaspence retitled this revision from to Add a "binary integer casing" linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:38 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 2 2015, 9:46 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2015, 9:46 PM
Closed by commit rARC3c193984da6f: Add a "binary integer casing" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 10:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35426

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistBinaryNumericScalarCasingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistHexadecimalNumericScalarCasingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/binary-numeric-scalar-casing/binary.lint-test

Loading...
Phabricator · Built by Phacility