Paths

Table of Contentst

Differential D14643

Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:33 PM.

Tags

None

Referenced Files

	F15381153: D14643.id.diff
	Fri, Mar 14, 6:09 AM

	F15335450: D14643.id35425.diff
	Sat, Mar 8, 3:29 PM

	Unknown Object (File)
	Mon, Mar 3, 11:28 PM

	Unknown Object (File)
	Thu, Feb 20, 3:31 AM

	Unknown Object (File)
	Wed, Feb 19, 11:07 PM

	Unknown Object (File)
	Wed, Feb 19, 5:36 PM

	Unknown Object (File)
	Wed, Feb 19, 2:16 AM

	Unknown Object (File)
	Feb 13 2025, 12:54 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCae3c2cb0e172: Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`

Summary

Binary integers (such as 0b1) were added to PHP 5.4 and cannot be used in earlier versions.

Test Plan

Added a test case.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9236
Build 10940: Run Core Tests
Build 10939: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	728 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	48 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	30 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 296 Passed · 44 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35425.Dec 2 2015, 9:33 PM

joshuaspence retitled this revision from to Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:33 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 2 2015, 9:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2015, 9:33 PM

Closed by commit rARCae3c2cb0e172: Add binary integers to `ArcanistPHPCompatibilityXHPASTLinterRule` (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 9:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

10 lines

__tests__/

php-compatibility/

php54-features.lint-test

3 lines

Diff 35425

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/php-compatibility/php54-features.lint-test

Loading...