Differential D14633

Linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 10:18 AM.

Tags

None

Referenced Files

	F15396370: D14633.diff
	Sun, Mar 16, 1:50 PM

	F15378894: D14633.diff
	Thu, Mar 13, 5:34 PM

	F15353691: D14633.diff
	Mon, Mar 10, 11:44 PM

	F15333521: D14633.diff
	Sat, Mar 8, 2:47 AM

	Unknown Object (File)
	Wed, Feb 19, 5:11 AM

	Unknown Object (File)
	Wed, Feb 19, 5:11 AM

	Unknown Object (File)
	Wed, Feb 19, 5:11 AM

	Unknown Object (File)
	Wed, Feb 19, 5:11 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCb52e9dc702c2: Linter fixes

Summary

Minor linter fixes

Test Plan

N/A

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9211
Build 10902: Run Core Tests
Build 10901: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	468 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	99 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	59 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 319 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35400.Dec 2 2015, 10:18 AM

joshuaspence retitled this revision from to Linter fixes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 10:18 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 5 2015, 12:27 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2015, 12:27 AM

Closed by commit rARCb52e9dc702c2: Linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 7 2015, 10:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistClassFilenameMismatchXHPASTLinterRule.php

2 lines

ArcanistImplicitFallthroughXHPASTLinterRule.php

2 lines

parser/

ArcanistBaseCommitParser.php

1 line

repository/

api/

ArcanistMercurialAPI.php

2 lines

ArcanistSubversionAPI.php

6 lines

unit/

engine/

NoseTestEngine.php

6 lines

PytestTestEngine.php

6 lines

workflow/

ArcanistFlagWorkflow.php

32 lines

Diff 35400

src/lint/linter/xhpast/rules/ArcanistClassFilenameMismatchXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistImplicitFallthroughXHPASTLinterRule.php

Loading...

src/parser/ArcanistBaseCommitParser.php

Loading...

src/repository/api/ArcanistMercurialAPI.php

Loading...

src/repository/api/ArcanistSubversionAPI.php

Loading...

src/unit/engine/NoseTestEngine.php

Loading...

src/unit/engine/PytestTestEngine.php

Loading...

src/workflow/ArcanistFlagWorkflow.php

Loading...