Page MenuHomePhabricator
Differential D14612

Add a linter rule for hexadecimal number casing
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 8:14 PM.
Tags
None
Referenced Files
F14045040: D14612.diff
Wed, Nov 13, 12:12 AM
F14037279: D14612.diff
Sun, Nov 10, 2:45 PM
F14029219: D14612.id35389.diff
Fri, Nov 8, 7:59 PM
F14029218: D14612.id35386.diff
Fri, Nov 8, 7:59 PM
F14029217: D14612.id35385.diff
Fri, Nov 8, 7:59 PM
F14029216: D14612.id35348.diff
Fri, Nov 8, 7:59 PM
F14029215: D14612.id.diff
Fri, Nov 8, 7:59 PM
F14029213: D14612.diff
Fri, Nov 8, 7:59 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC00efcd294fd0: Add a linter rule for hexadecimal number casing
Summary

Hexadecimal numbers should be written as 0xFF and not 0xff or 0Xff.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9196
Build 10879: Run Core Tests
Build 10878: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
721 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
89 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
24 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
55 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
10 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 292 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35348.Nov 30 2015, 8:14 PM
joshuaspence retitled this revision from to Add a linter rule for hexadecimal number casing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 8:14 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 30 2015, 8:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 8:15 PM
joshuaspence updated this revision to Diff 35385.Dec 1 2015, 8:45 PM
joshuaspence edited edge metadata.

Minor rename

joshuaspence updated this revision to Diff 35386.Dec 1 2015, 8:50 PM

Fix autofix

Closed by commit rARC00efcd294fd0: Add a linter rule for hexadecimal number casing (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 2:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35386

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistHexadecimalNumericScalarCasingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistHexadecimalNumericScalarCasingXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/hexadecimal-numeric-scalar-casing/hexadecimal.lint-test

Loading...
Phabricator · Built by Phacility