Differential D14623

Fix another edge case for "function call should be type cast" linter rule
ClosedPublic
Actions

Authored by joshuaspence on Dec 1 2015, 7:18 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC76ae02325dd3: Fix another edge case for "function call should be type cast" linter rule

Summary

Fix a minor issue in which changing a function call to a type cast affects the result of an expression.

Test Plan

Added test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9186
Build 10862: Run Core Tests
Build 10861: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	577 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	41 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	24 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 290 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35376.Dec 1 2015, 7:18 PM

joshuaspence retitled this revision from to Fix another edge case for "function call should be type cast" linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2015, 7:18 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 1 2015, 10:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 1 2015, 10:44 PM

Closed by commit rARC76ae02325dd3: Fix another edge case for "function call should be type cast" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 3:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

8 lines

__tests__/

function-call-should-be-type-cast/

binary-expression.lint-test

7 lines

Diff 35376

View Options

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/function-call-should-be-type-cast/binary-expression.lint-test

Fix another edge case for "function call should be type cast" linter ruleClosedPublicActions